Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local docker compose debugging #1564

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Add local docker compose debugging #1564

merged 6 commits into from
Nov 4, 2024

Conversation

hacktobeer
Copy link
Collaborator

@hacktobeer hacktobeer commented Nov 1, 2024 •
edited
Loading

Description of the change

Add local docker compose debugging settings and vscode launch configurations. This allows for local docker compose debugging of worker and server in vscode.

Extra:

  • add local runtime folders to docker ignore files.
  • add helper setup.sh to setup local docker compose folders.

Applicable issues

None

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@hacktobeer hacktobeer marked this pull request as ready for review November 1, 2024 19:58
wajihyassine
wajihyassine approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@wajihyassine wajihyassine left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per side chat and failing test is unrelated, LGTM

@wajihyassine wajihyassine merged commit cb804a2 into google:master Nov 4, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wajihyassine wajihyassine wajihyassine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacktobeer @wajihyassine