-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add request/response debug logging to gapics #1671
base: main
Are you sure you want to change the base?
Conversation
FYI, there are a couple of meaty comments on the older PR that should be addressed here. Also we don't plan to actually regen based on this until after EOY. |
Found during this work and put aside for now: #1684 |
Moving this reply to @sofisl over here so I can close the other PR:
Sounds good!
I don't quite understand about the double-printing, do you mean that we'd be printing stuff from the request in the response? I think, in general, there shouldn't be duplication.
Doh. Yes. (update: these should also be done now)
I will take a look, but the intention of (update: These particular issues should be fixed now, but it looks like some other stuff remains.)
Okay, that sounds fine to me. You'd know more about the structure of these particular packages than me. :) |
This adds request/response logging for all gapic libraries, in both cjs and esm.
This is a duplicate of another PR to comply with some process changes.