Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: compress RetryPolicy class hierarchy #14947

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Jan 17, 2025

This change is Reviewable

@scotthart scotthart added the do not review Indicates a PR is not ready for review label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.91%. Comparing base (ee8c2bb) to head (a3b3383).

Files with missing lines Patch % Lines
...v1/internal/golden_kitchen_sink_connection_impl.cc 50.00% 1 Missing ⚠️
...ternal/golden_kitchen_sink_rest_connection_impl.cc 50.00% 1 Missing ⚠️
.../v1/internal/golden_thing_admin_connection_impl.cc 80.00% 1 Missing ⚠️
...nternal/golden_thing_admin_rest_connection_impl.cc 80.00% 1 Missing ⚠️
google/cloud/bigtable/testing/mock_policies.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #14947    +/-   ##
========================================
  Coverage   92.91%   92.91%            
========================================
  Files        2351     2351            
  Lines      210082   209859   -223     
========================================
- Hits       195190   194991   -199     
+ Misses      14892    14868    -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not review Indicates a PR is not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant