Skip to content

Commit

Permalink
feat!: Spanner V2
Browse files Browse the repository at this point in the history
  • Loading branch information
bshaffer committed Nov 20, 2024
1 parent eeba775 commit fd840b9
Show file tree
Hide file tree
Showing 159 changed files with 8,655 additions and 19,204 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/system-tests-spanner-emulator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Install dependencies
run: |
# ensure composer uses local Core instead of pulling from packagist
composer config repositories.local --json '{"type":"path", "url": "../Core", "options": {"versions": {"google/cloud-core": "1.100"}}}' -d Spanner
# composer config repositories.local --json '{"type":"path", "url": "../Core", "options": {"versions": {"google/cloud-core": "1.100"}}}' -d Spanner
composer update --prefer-dist --no-interaction --no-suggest -d Spanner/
- name: Run system tests
Expand Down
4 changes: 2 additions & 2 deletions Core/src/ApiHelperTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ private function splitOptionalArgs(array $input, array $extraAllowedKeys = []) :
$callOptionFields = array_keys((new CallOptions([]))->toArray());
$keys = array_merge($callOptionFields, $extraAllowedKeys);

$optionalArgs = $this->pluckArray($keys, $input);
$callOptions = $this->pluckArray($keys, $input);

return [$input, $optionalArgs];
return [$input, $callOptions];
}
}
2 changes: 1 addition & 1 deletion Core/src/Iam/Iam.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
*
* use Google\Cloud\Spanner\SpannerClient;
*
* $spanner = new SpannerClient();
* $spanner = new SpannerClient(['projectId' => 'my-project']);
* $instance = $spanner->instance('my-new-instance');
*
* $iam = $instance->iam();
Expand Down
86 changes: 86 additions & 0 deletions Core/src/Middleware/ExceptionMiddleware.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
<?php
/*
* Copyright 2024 Google LLC
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
* met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following disclaimer
* in the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Google Inc. nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

namespace Google\Cloud\Core\Middleware;

use Google\ApiCore\ApiException;
use Google\ApiCore\BidiStream;
use Google\ApiCore\Call;
use Google\ApiCore\ClientStream;
use Google\ApiCore\Middleware\MiddlewareInterface;
use Google\ApiCore\ServerStream;
use Google\Cloud\Core\RequestProcessorTrait;
use GuzzleHttp\Promise\PromiseInterface;
use Throwable;

/**
* Middleware that wraps any Api Exception to a `Google\Cloud\Core\Exception`
* exception class. This is primarily to maintain backwards compatibility with
* previous Spanner versions.
*
* @internal
*/
class ExceptionMiddleware implements MiddlewareInterface
{
use RequestProcessorTrait;

/** @var callable */
private $nextHandler;

public function __construct(callable $nextHandler) {
$this->nextHandler = $nextHandler;
}

/**
* @param Call $call
* @param array $options
*
* @return PromiseInterface|ClientStream|ServerStream|BidiStream
*/
public function __invoke(Call $call, array $options)
{
$response = ($this->nextHandler)($call, $options);
if ($response instanceof PromiseInterface) {
return $response->then(null, function ($value) {
if ($value instanceof \Google\ApiCore\ApiException) {
throw $this->convertToGoogleException($value);
}
if ($value instanceof Throwable) {
throw $value;
}
});
}
// this can also be a Stream
return $response;
}
}

15 changes: 9 additions & 6 deletions Core/src/RequestHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ class RequestHandler
*/
private Serializer $serializer;

private array $clients;
private array $clients = [];

/**
* @param Serializer $serializer
* @param array $clientClasses
* @param array<string|object> $clientClasses
* @param array $clientConfig
*/
public function __construct(
Expand All @@ -76,11 +76,14 @@ public function __construct(
);
}
//@codeCoverageIgnoreEnd

// Initialize the client classes and store them in memory
$this->clients = [];
foreach ($clientClasses as $className) {
$this->clients[$className] = new $className($clientConfig);
foreach ($clientClasses as $client) {
if (is_object($client)) {
$this->clients[get_class($client)] = $client;
} else {
$this->clients[$client] = new $client($clientConfig);
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion Core/src/ServiceBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ public function pubsub(array $config = [])
*
* Example:
* ```
* $spanner = $cloud->spanner();
* $spanner = $cloud->spanner(['projectId' => 'my-project']);
* ```
*
* @param array $config [optional] {
Expand Down
4 changes: 2 additions & 2 deletions Core/src/TimeTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ private function formatTimeAsString(\DateTimeInterface $dateTime, $ns)
* $dateTime will be used instead.
* @return array
*/
private function formatTimeAsArray(\DateTimeInterface $dateTime, $ns)
private function formatTimeAsArray(\DateTimeInterface $dateTime, $ns = null)
{
if ($ns === null) {
$ns = $dateTime->format('u');
$ns = $this->convertFractionToNanoSeconds($dateTime->format('u'));
}
return [
'seconds' => (int) $dateTime->format('U'),
Expand Down
3 changes: 2 additions & 1 deletion Core/tests/Snippet/Iam/IamTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

use Google\Cloud\Core\Testing\Snippet\SnippetTestCase;
use Google\Cloud\Core\Iam\Iam;
use Google\Cloud\Core\Iam\IamManager;
use Google\Cloud\Core\Iam\IamConnectionInterface;
use Google\Cloud\Core\Testing\TestHelpers;
use Google\Cloud\Spanner\SpannerClient;
Expand Down Expand Up @@ -55,7 +56,7 @@ public function testClass()
]);
$res = $snippet->invoke('iam');

$this->assertInstanceOf(Iam::class, $res->returnVal());
$this->assertInstanceOf(IamManager::class, $res->returnVal());
}

public function testPolicy()
Expand Down
2 changes: 1 addition & 1 deletion Core/tests/Unit/LongRunning/OperationResponseTraitTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
namespace Google\Cloud\Core\Tests\Unit\LongRunning;

use Google\ApiCore\OperationResponse;
use Google\ApiCore\Serializer;
use Google\Cloud\Core\LongRunning\OperationResponseTrait;
use Google\Cloud\Core\LongRunning\LongRunningOperation;
use Google\Cloud\Core\LongRunning\LongRunningConnectionInterface;
use Google\ApiCore\Serializer;
use Prophecy\Argument;
use Google\Cloud\Audit\RequestMetadata;
use Google\Cloud\Audit\AuthorizationInfo;
Expand Down
6 changes: 0 additions & 6 deletions Core/tests/Unit/ServiceBuilderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
use Google\Cloud\Firestore\FirestoreClient;
use Google\Cloud\Language\LanguageClient;
use Google\Cloud\Logging\LoggingClient;
use Google\Cloud\Spanner\SpannerClient;
use Google\Cloud\Speech\SpeechClient;
use Google\Cloud\Storage\StorageClient;
use Google\Cloud\Core\Tests\Unit\Fixtures;
Expand Down Expand Up @@ -175,11 +174,6 @@ public function serviceProvider()
], [
'language',
LanguageClient::class
], [
'spanner',
SpannerClient::class,
[],
[$this, 'checkAndSkipGrpcTests']
], [
'speech',
SpeechClient::class,
Expand Down
115 changes: 115 additions & 0 deletions Spanner/MIGRATING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
# Migrating Google Spanner from V1 to V2

## How to upgrade

Update your `google/cloud-spanner` dependency to `^2.0`:

```
{
"require": {
"google/cloud-spanner": "^2.0"
}
}
```

## Changes

### Client Options changes

The following client options are removed/replaced with other options present in
[`ClientOptions`][ClientOptions]. This was done to ensure client options are consistent across all
Google Cloud clients.

- `authCache` -> Moved to `credentialsConfig.authCache`
- `authCacheOptions` -> Moved to `credentialsConfig.authCacheOptions`
- `FetchAuthTokenInterface` -> Moved to `credentials`
- `keyFile` -> Moved to `credentials`
- `keyFilePath` -> Moved to `credentials`
- `requestTimeout` -> Removed from client options and moved to a call option `timeoutMillis`
- `scopes` -> Moved to `credentialsConfig.scopes`
- `quotaProject` -> Moved to `credentialsConfig.quotaProject`
- `httpHandler` -> Moved to `transportConfig.rest.httpHandler`
- `authHttpHandler` -> Moved to `credentialsConfig.authHttpHandler`
- `retries` -> Removed from client options and moved to call options `retrySettings.maxRetries`

### Retry Options changes

The retry options have been moved to use [`RetrySettings`][RetrySettings] in call options
and function parameters.

- `retries` -> Renamed to `retrySettings.maxRetries`
- `maxRetries` -> Renamed to `retrySettings.maxRetries`

[RetrySettings]: https://googleapis.github.io/gax-php/v1.26.1/Google/ApiCore/RetrySettings.html

[ClientOptions]: https://googleapis.github.io/gax-php/v1.26.1/Google/ApiCore/Options/ClientOptions.html

### Connection classes are not used anymore.

This is a major change with this major version but one that we hope won't break any users. When the
`SpannerClient` was created, behind the scenes a connection adapter was initialized.
This connection object was then forwarded to any resource classes internally,
like so:

```php
// This initialized a connection object
$client = new SpannerClient();
// This passed on the connection object to the Instance class
$instance = $spanner->instance('my-instance');
```

As you can see the connection object was handled internally. If you used the library in this way,
you will not need to make any changes. However, if you created the connection classes directly
and passed it to the `Instance` class, this will break in Spanner `v2`:

```php
// Not intended
$connObj = new Grpc([]);
$instance = new Instance(
$connObj,
// other constructor options
);
```

### `Google\Cloud\Spanner\Duration` class is not used anymore.
We have removed the `Google\Cloud\Spanner\Duration` class from the library. Instead we will be using the `Google\Protobuf\Duration` class.

### IAM class changes

We have kept the functionality of `IAM` the same, however the underlying `IAM` class has changed.
```php
// In V1, this used to return an instance of Google\Cloud\Core\Iam\Iam
$iam = $instance->iam();

// In V2, this will return an instance of Google\Cloud\Core\Iam\IamManager
$iam = $instance->iam();

// Both the classes share the same functionality, so the following methods will work for both versions.
$iam->policy();
$iam->setPolicy();
$iam->testIamPermissions();
```

### LongRunningOperation class changes

We have kept the functionality of `LongRunningOperation` the same,
however the underlying `LongRunningOperation` class has changed.
```php
// In V1, this used to return an instance of Google\Cloud\Core\LongRunning\LongRunningOperation.
$lro = $instance->create($configuration);

// In V2, this will return an instance of Google\ApiCore\OperationResponse.
$lro = $instance->create($configuration);

// Both the classes share the same functionality, so the following methods will work for both versions.
$lro->name();
$lro->done();
$lro->state();
$lro->result();
$lro->error();
$lro->info();
$lro->reload();
$lro->pollUntilComplete();
$lro->cancel();
$lro->delete();
```
19 changes: 16 additions & 3 deletions Spanner/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"require": {
"php": "^8.0",
"ext-grpc": "*",
"google/cloud-core": "^1.52.7",
"google/gax": "^1.34.0"
"google/cloud-core": "1.60",
"google/gax": "dev-result-function as 1.40.0"
},
"require-dev": {
"phpunit/phpunit": "^9.0",
Expand All @@ -16,7 +16,9 @@
"phpdocumentor/reflection": "^5.3.3",
"phpdocumentor/reflection-docblock": "^5.3",
"erusev/parsedown": "^1.6",
"google/cloud-pubsub": "^2.0"
"google/cloud-pubsub": "^2.0",
"dg/bypass-finals": "^1.7",
"dms/phpunit-arraysubset-asserts": "^0.5.0"
},
"suggest": {
"ext-protobuf": "Provides a significant increase in throughput over the pure PHP protobuf implementation. See https://cloud.google.com/php/grpc for installation instructions.",
Expand All @@ -40,5 +42,16 @@
"psr-4": {
"Google\\Cloud\\Spanner\\Tests\\": "tests"
}
},
"repositories": {
"google-cloud": {
"type": "path",
"url": "../Core",
"options": {
"versions": {
"google/cloud-core": "1.60"
}
}
}
}
}
2 changes: 1 addition & 1 deletion Spanner/phpunit.xml.dist
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" colors="true" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="./tests/Unit/bootstrap.php" colors="true" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
<coverage>
<include>
<directory suffix=".php">src</directory>
Expand Down
Loading

0 comments on commit fd840b9

Please sign in to comment.