Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add integration test to ensure that reverse scan resumption produces correct results #2029

Merged
merged 8 commits into from
Dec 11, 2023
Merged

test: add integration test to ensure that reverse scan resumption produces correct results #2029

merged 8 commits into from
Dec 11, 2023

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Dec 11, 2023 •
edited
Loading

Change-Id: I909ec95bebe87219d66b387cd80e7095e75252a2

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@igorbernstein2 igorbernstein2 requested a review from a team as a code owner December 11, 2023 17:03
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 11, 2023
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner December 11, 2023 17:06
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2023
@igorbernstein2
test: add integration test to ensure that reverse scan resumption pro…
9ff12b4 
…duces correct results

Change-Id: I909ec95bebe87219d66b387cd80e7095e75252a2
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 11, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 11, 2023
@igorbernstein2 igorbernstein2 changed the title test: add integration test to ensure that reverse scan resumption pro… test: add integration test to ensure that reverse scan resumption produces correct results Dec 11, 2023
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 11, 2023
@igorbernstein2
stale code
b89b698 
Change-Id: I00d8020a441a6520d22a91ee12b825a05b840040
@gcf-merge-on-green gcf-merge-on-green bot merged commit 24f8cc0 into main Dec 11, 2023
22 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the rev-scans-resume branch December 11, 2023 21:14
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorbernstein2 @mutianf @yoshi-kokoro