Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add a missing @Test annotation #2068

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Jan 23, 2024

Fixes #2067

@cushon cushon requested a review from a team as a code owner January 23, 2024 17:25
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jan 23, 2024
@kolea2 kolea2 changed the title Add a missing @Test annotation test: Add a missing @Test annotation Jan 23, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @cushon the only check that's failing is the conventional commit check - if you could please amend the commit message to include the test:.. prefix as I have edited the title with, the check will pass and I will be able to merge this in. Thanks again for your contribution!

@cushon
Copy link
Contributor Author

cushon commented Jan 23, 2024

I have amended the commit message. Thanks for the review!

@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 23, 2024
@kolea2 kolea2 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 23, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2024
@cushon cushon requested a review from a team as a code owner January 23, 2024 18:03
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3d86f91 into googleapis:main Jan 23, 2024
20 of 21 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 23, 2024
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing JUnit @Test annotation on EnhancedBigtableStubSettingsTest#enableRetryInfoDefaultValueTest
3 participants