Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error from fill method should not be emitted #2233

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Conversation

surbhigarg92
Copy link
Contributor

Fixes #2106

@surbhigarg92 surbhigarg92 requested review from a team as code owners February 7, 2025 07:22
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Feb 7, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Feb 7, 2025
@surbhigarg92 surbhigarg92 changed the title fix: rollback with no id (#2231) fix: error from fill method should not be emitted Feb 7, 2025
@surbhigarg92 surbhigarg92 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 7, 2025
@surbhigarg92 surbhigarg92 merged commit 2cc44cf into main Feb 17, 2025
19 of 22 checks passed
@surbhigarg92 surbhigarg92 deleted the issue_2016 branch February 17, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database not found and other errors emitted when they shouldn't be
2 participants