This repository has been archived by the owner on May 15, 2023. It is now read-only.
Publish Docker Images to GH Packages on merge with main #86
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: Build Docker Images & Push to Registry | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Build Frontend Docker image | ||
| working-directory: ./app | ||
| run: | | ||
| docker login docker.pkg.github.com -u ${{ secrets.USERNAME }} --password ${{ secrets.GITHUB_TOKEN }} | ||
| docker build . --file Dockerfile --tag frontend | ||
| docker tag frontend docker.pkg.github.com/googleinterns/major-tom/frontend | ||
|
There was a problem hiding this comment. Correct me if I am wrong but, are these URL's correct? I thought that for pushing to Google's Container Registry you had to prefix your images with the following format: There was a problem hiding this comment. I think this pr is about publishing our latest image to the repo not to gcp's container registry |
||
| docker push docker.pkg.github.com/googleinterns/major-tom/frontend | ||
| - name: Build Backend Docker image | ||
| working-directory: ./server | ||
| run: | | ||
| docker build . --file Dockerfile --tag backend | ||
| docker tag backend docker.pkg.github.com/googleinterns/major-tom/backend | ||
|
There was a problem hiding this comment. Isn't this tag lost if you don't push it with this tag too? |
||
| docker push docker.pkg.github.com/googleinterns/major-tom/backend | ||
| - name: Build Keywords Docker image | ||
| working-directory: ./services/keywords | ||
| run: | | ||
| docker build . --file Dockerfile --tag keywords | ||
| docker tag keywords docker.pkg.github.com/googleinterns/major-tom/keywords | ||
| docker push docker.pkg.github.com/googleinterns/major-tom/keywords | ||
| - name: Build Search Docker image | ||
| working-directory: ./services/search | ||
| run: | | ||
| docker build . --file Dockerfile --tag search | ||
| docker tag search docker.pkg.github.com/googleinterns/major-tom/search | ||
| docker push docker.pkg.github.com/googleinterns/major-tom/search | ||
| - name: Build Parser Docker image | ||
| working-directory: ./services/parser-database | ||
| run: | | ||
| docker build . --file Dockerfile --tag parser-database | ||
|
There was a problem hiding this comment. I am pretty confident you can omit the |
||
| docker tag parser-database docker.pkg.github.com/googleinterns/major-tom/parser-database | ||
| docker push docker.pkg.github.com/googleinterns/major-tom/parser-database | ||
|
Comment on lines
+12
to
+42
There was a problem hiding this comment. the |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a cloudbuild yaml? I would leave cloudbuild in the name somewhere if so