Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Piotr <[email protected]>
  • Loading branch information
3 people authored Jul 12, 2024
1 parent 8f3ab0c commit 9eb4221
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/sources/flow/reference/components/loki.process.md
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ The following blocks are supported inside the definition of `stage.metrics`:
| metric.histogram | [metric.histogram][] | Defines a `histogram` metric. | no |

{{< admonition type="note" >}}
If the configuration file for {{< param "PRODUCT_ROOT_NAME" >}} is reloaded, the metrics will be reset.
The metrics will be reset if you reload the {{< param "PRODUCT_ROOT_NAME" >}} configuration file.
{{< /admonition >}}

[metric.counter]: #metriccounter-block
Expand Down
2 changes: 1 addition & 1 deletion internal/component/loki/process/process_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ loki_process_custom_paulin_test{filename="/var/log/pods/agent/agent/1.log",foo="
}
}

// Make sure there are no metrics - there is no metrics stage in the latest config.
// Make sure there are still no metrics after sending log entries.
if err := testutil.GatherAndCompare(reg,
strings.NewReader("")); err != nil {
t.Fatalf("mismatch metrics: %v", err)
Expand Down

0 comments on commit 9eb4221

Please sign in to comment.