-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first chapter of flow-by-example to docs #5888
Add first chapter of flow-by-example to docs #5888
Conversation
@spartan0x117 We can include the YAML in the same directory as the tutorial, or you can add it to an assets directory similar to what has been done here: https://github.com/grafana/agent/tree/main/docs/sources/flow/tutorials/assets |
We should move all the screenshots/diagrams to the right location: https://grafana.com/docs/writers-toolkit/write/image-guidelines/#where-to-store-media-assets |
Do the existing tutorials still hold educational value? Should this fully supplant the existing tutorials? |
…y, add docker-compose and update FAQ
My take on it... they should be removed or re-worked into a more comprehensive tutorials. |
If we go that route, should that be done in this PR or a separate one? |
I'd say a separate PR... otherwise we overload this one with scope creep. :-) |
docs/sources/flow/tutorials/flow-by-example/first-components-and-stdlib/index.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/tutorials/flow-by-example/first-components-and-stdlib/index.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/tutorials/flow-by-example/first-components-and-stdlib/index.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/tutorials/flow-by-example/first-components-and-stdlib/index.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/tutorials/flow-by-example/first-components-and-stdlib/index.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/tutorials/flow-by-example/first-components-and-stdlib/index.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/tutorials/flow-by-example/first-components-and-stdlib/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
I made a few changes after more carefully going through the writer's toolkit, mostly as individual commits that we can back out, if needed:
|
Good to know! 😄 In this case I was aiming to hide it entirely unless a reader wants to see a potential solution (and do so ideally without having to leave the page). |
This PR has not had any activity in the past 30 days, so the |
@spartan0x117 Are we done here? I think the docs are good enough to publish as-is.. get the info out there and we can update as needed. |
Yeah I think this one should be good to go! I can merge on Monday and then work on adding the other tutorial sections 😃 |
@spartan0x117 Merged it |
* Add first chapter of flow-by-example to docs * Update strucutre to leaf bundles, move some assets to shared directory, add docker-compose and update FAQ * Remove unnecessary assets and change to /media/ links * Apply suggestions from code review Co-authored-by: Clayton Cornell <[email protected]> * Add note admonitions and fix some links * Rename faq.md -> get-started.md and update description * Replace 'Grafana Agent in Flow mode' with PRODUCT_NAME param * Remove solution file and use a collapse shortcode with a code block instead * Change to repetitive list and shift paragraph content to new line for each * Switch Headline Case -> Sentence case * Replace relrefs with full urls * Add <AGENT_VERSION> to links * Remove docker-compose.yaml and download and add it as a code block to get-started * Add weights to fix ordering --------- Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 77aac50)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-5888-to-release-v0.39 origin/release-v0.39
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 77aac507124cdf2d5aef2bbfb5d7ec7024a33daf
# Push it to GitHub
git push --set-upstream origin backport-5888-to-release-v0.39
git switch main
# Remove the local backport branch
git branch -D backport-5888-to-release-v0.39 Then, create a pull request where the |
…6176) * Add first chapter of flow-by-example to docs (#5888) * Add first chapter of flow-by-example to docs * Update strucutre to leaf bundles, move some assets to shared directory, add docker-compose and update FAQ * Remove unnecessary assets and change to /media/ links * Apply suggestions from code review Co-authored-by: Clayton Cornell <[email protected]> * Add note admonitions and fix some links * Rename faq.md -> get-started.md and update description * Replace 'Grafana Agent in Flow mode' with PRODUCT_NAME param * Remove solution file and use a collapse shortcode with a code block instead * Change to repetitive list and shift paragraph content to new line for each * Switch Headline Case -> Sentence case * Replace relrefs with full urls * Add <AGENT_VERSION> to links * Remove docker-compose.yaml and download and add it as a code block to get-started * Add weights to fix ordering --------- Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 77aac50) * trigger CI --------- Co-authored-by: Mischa Thompson <[email protected]>
* Add first chapter of flow-by-example to docs * Update strucutre to leaf bundles, move some assets to shared directory, add docker-compose and update FAQ * Remove unnecessary assets and change to /media/ links * Apply suggestions from code review Co-authored-by: Clayton Cornell <[email protected]> * Add note admonitions and fix some links * Rename faq.md -> get-started.md and update description * Replace 'Grafana Agent in Flow mode' with PRODUCT_NAME param * Remove solution file and use a collapse shortcode with a code block instead * Change to repetitive list and shift paragraph content to new line for each * Switch Headline Case -> Sentence case * Replace relrefs with full urls * Add <AGENT_VERSION> to links * Remove docker-compose.yaml and download and add it as a code block to get-started * Add weights to fix ordering --------- Co-authored-by: Clayton Cornell <[email protected]>
PR Description
Adds the first section of flow-by-example to the docs. Note I'm not super familiar with the metadata at the top of the docs, but when looking at the docs locally everything seemed reasonable.
Notes to the Reviewer
@clayton-cornell where would be the most appropriate place to include the docker-compose so users can easily use it?
PR Checklist