Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otelcol.connector.host_info component #6410

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

rlankfo
Copy link
Member

@rlankfo rlankfo commented Feb 20, 2024

PR Description

Introduce otelcol.connector.host_info component.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc tweak

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 20, 2024
metrics, count := c.hostMetrics.metrics()
if count > 0 {
c.hostMetrics.reset()
c.logger.Info("Flushing metrics", zap.Int("count", count))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we make this debug level?

Copy link
Contributor

@jcreixell jcreixell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments, overall LGTM

@rlankfo rlankfo changed the title Add otelcol.connector.grafanacloud component Add otelcol.connector.host_info component Feb 21, 2024
@rlankfo rlankfo force-pushed the grafanacloudconnector branch 2 times, most recently from 6f9e7ae to d459395 Compare February 21, 2024 21:59
@rlankfo rlankfo force-pushed the grafanacloudconnector branch from d8a18e8 to 88821f4 Compare February 21, 2024 23:01
@rlankfo rlankfo merged commit 7a8d6c5 into main Feb 22, 2024
10 checks passed
@rlankfo rlankfo deleted the grafanacloudconnector branch February 22, 2024 00:01
jcreixell added a commit that referenced this pull request Feb 22, 2024
  - This is just a cleanup from a previous refactoring
  - See #6410
jcreixell added a commit that referenced this pull request Feb 22, 2024
- This is just a cleanup from a previous refactoring
  - See #6410

```river
otelcol.connector.host_info "LABEL" {
output {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This output block is not documented for some reason? cc @jcreixell

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this @thampiotr. opened a pr to document this block: #6488

wildum pushed a commit that referenced this pull request Feb 26, 2024
- This is just a cleanup from a previous refactoring
  - See #6410
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants