-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add otelcol.connector.host_info
component
#6410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor doc tweak
docs/sources/flow/reference/components/otelcol.connector.grafanacloud.md
Outdated
Show resolved
Hide resolved
metrics, count := c.hostMetrics.metrics() | ||
if count > 0 { | ||
c.hostMetrics.reset() | ||
c.logger.Info("Flushing metrics", zap.Int("count", count)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we make this debug level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments, overall LGTM
otelcol.connector.grafanacloud
componentotelcol.connector.host_info
component
6f9e7ae
to
d459395
Compare
Signed-off-by: Robbie Lankford <[email protected]>
d8a18e8
to
88821f4
Compare
- This is just a cleanup from a previous refactoring - See #6410
- This is just a cleanup from a previous refactoring - See #6410
|
||
```river | ||
otelcol.connector.host_info "LABEL" { | ||
output { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This output block is not documented for some reason? cc @jcreixell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching this @thampiotr. opened a pr to document this block: #6488
- This is just a cleanup from a previous refactoring - See #6410
PR Description
Introduce
otelcol.connector.host_info
component.PR Checklist