Move wal queue to its own repository and minor bug fixes. #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
changed the title
auto-merge was automatically disabled
October 31, 2024 11:31
Pull request was converted to draft
|
Setting this back to draft, since I am going to move this functionality into a fork. |
mattdurham
changed the title
mattdurham
changed the title
thampiotr
approved these changes
Nov 15, 2024
Co-authored-by: Piotr <[email protected]>
|
This also fixes #2074 |
vaxvms
pushed a commit
to vaxvms/alloy
that referenced
this pull request
Nov 20, 2024
* Working on wal cleanup * use wrapped mailboxes * more safely use mailboxes. * Fix check that is no longer needed. * Cleanup * Add test for metrics. * remove check * fix check * lower threshold * The go func was bogging down tests. * Adjusting times. * Fix issue with items not being put back into the timeseries pool. * Add comment. * Remove unneeded test. * Use the same concepts. * Use the same concepts. * Switch to using the walqueue repo. * add changelog * Fix go.mod and empty file. * update go.mod * remove unneeded file and update to cleaner code for walqueue. * Remove race exclusion * Remove race exclusion * Update CHANGELOG.md Co-authored-by: Piotr <[email protected]> --------- Co-authored-by: Piotr <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the queue implementation to a separate repo github.com/grafana/walqueue. In that repo I made changes to support reloading configuration and preventing duplicate metric registration on config relods.