Live debugging front #977
Merged
Live debugging front #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreixell
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
LGTM, the changes are consistent with the previous code we wrote for the POC, which we tested thoroughly. I don't love the colors of the buttons on the top right, but they are functional and we can always make cosmetic improvements later. Looking forward to seeing this released!
wildum
added a commit
that referenced
this pull request
Jun 7, 2024
* add live debugging page in UI * change button size * move icon in front of text in buttons * add warning if the number of incoming lines is greater than the buffer size
wildum
added a commit
that referenced
this pull request
Jun 11, 2024
* Live debugging service with prometheus.relabel (#797) * create xray service to manage the debug streams * add xray support to the prometheus.relabel component * add xray endpoint to the api * rename handler to manager * defer cleanup func * rework to add multi-streams support * more tests * additional multi delete test * add todo comment for buffer size * add error checks * improve naming and readability, split interfaces and add a check to avoid expensive string computation * move register and isregistered to a new debugRegistry interface * Live debugging front (#977) * add live debugging page in UI * change button size * move icon in front of text in buttons * add warning if the number of incoming lines is greater than the buffer size * Live debugging doc (#987) * add live debugging doc * Update docs/sources/tasks/debug.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/tasks/debug.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/tasks/debug.md Co-authored-by: Clayton Cornell <[email protected]> * improve doc * Update docs/sources/tasks/debug.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]> * changelog * add list of supported components in debug.md * switch to pull based registration * switch stability to GA * update changelog * use monospace font for log lines * copy to clipboard now copies the filtered data * disable livedebugging by default and add a config block to enable it. The stability is also updated to experimental * Update docs/sources/reference/config-blocks/livedebugging.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/reference/config-blocks/livedebugging.md Co-authored-by: Clayton Cornell <[email protected]> * replace debugging data by live debugging data in the doc * update screenshots * Update docs/sources/reference/config-blocks/livedebugging.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/reference/config-blocks/livedebugging.md Co-authored-by: Clayton Cornell <[email protected]> * small doc fix --------- Co-authored-by: Clayton Cornell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR WILL BE MERGED TO A FEATURE BRANCH WHICH WILL RECEIVE A FEW OTHER PRs BEFORE BEING READY TO BE MERGED ON MAIN
This PR is the second part of the live debugging functionality.
It adds a live debugging page in the front-end:
Screen.Recording.2024-06-03.at.16.09.35.mov
The live debugging uses a 5000 lines buffer to display the feed. Once the buffer is full, old lines are removed.
The user:
It supports modules.
Fixes #831