fix(gcp): Update cost calculation of PVC's to convert size to GiB #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new method to `Disks` to convert the disk size from GB to GiB and implements unit tests for said method. Updates documentation and metric name to clarify that the metric already takes into account the size and cost of the disk. Other metrics export the raw cost per hour. - closes #153
Pokom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new method to
Disksto convert the disk size from GB to GiB and implements unit tests for said method.Updates documentation and metric name to clarify that the metric already takes into account the size and cost of the disk. Other metrics export the raw cost per hour.
This is largely necessary because the pricing from GCP is in GiB, but the disk's size is reported in GB.