-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paula/add ebs pricing metrics #240
Conversation
5f47120
to
da59c8c
Compare
36d1ebd
to
1d32a5e
Compare
I've organised the changes into two more meaningful commits to make final review easier. First one is just a no-op refactor of the old code to prepare it to fit the new bits. Second one adds all the new functionality. I think I've addressed all previous comments. This code is now ready to review 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I have to sign off for the day, but I think this should be a sizeable chunk... :)
Main things:
- This is an awesome start. All the building blocks are there, it just needs a little bit of tweaking
- The biggest thing that I noticed was that we should not be creating as many
context
objects, rather prefer to pass them into functions from their "parent", usually the EC2 or AWS Collector - Current cost of volumes appears to be in USD/mo rather than USD/hr
- Implement locking when writing to the StorageMap
- Implement a logger on the StorageMap so we can avoid
log.Print
553b3ce
to
9d4e733
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress! I think with just a few touch-ups, we should be good here!
Note: I'm going to continue to noodle on the waitgroup test + channels closing and see if I can figure out something useful there.
98701bf
to
7d79ceb
Compare
5f219e3
to
cb43f60
Compare
re #235
This PR:
Next steps, out of the scope of this PR:
This code emits metrics in this format:
The labels aren't necessarily the final ones we'll settle on, but rather a starting point to see how those serve us. Naming is subject to change too.