Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loki role #188

Merged
merged 21 commits into from
Apr 29, 2024
Merged

feat: add loki role #188

merged 21 commits into from
Apr 29, 2024

Conversation

voidquark
Copy link
Collaborator

solving issue - #187

Migration of https://github.com/voidquark/loki into the Grafana collection.

I've integrated molecule testing for the Loki role, leveraging the same approach used in the previous repository. Results are under actions->loki-molecule.

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2024

CLA assistant check
All committers have signed the CLA.

@ishanjainn
Copy link
Member

cc @GVengelen as you had mentioned about adding a Loki role, Do you wanna take a pass at this too?

@GVengelen
Copy link
Collaborator

cc @GVengelen as you had mentioned about adding a Loki role, Do you wanna take a pass at this too?

Yes, will have a look this weekend

@GVengelen
Copy link
Collaborator

@voidquark looks to me. To be inline with other roles, could you add examples?

@voidquark
Copy link
Collaborator Author

@GVengelen I've included two examples in 7be7334 . One demonstrates a simple default role deployment, while the other showcases a local filesystem deployment with retention settings and an example alerting rule.

@ishanjainn
Copy link
Member

LGTM me too!
@voidquark I sent you an invite to add you as a collaborator in this repo. Once you accept I think we should be good to merge.

Also, Like i mentioned to @GVengelen aswell, Do you wanna write. a blogpost on the grafana's blog about this role, If yes, Could you share the google doc link(Can be empty for now, Just need the link so that I can check it later once you have it completed)

@voidquark
Copy link
Collaborator Author

@ishanjainn I have accepted the invitation.

@voidquark
Copy link
Collaborator Author

@ishanjainn Once merged. I'll keep you updated on the progress of the blog post via Slack.

@ishanjainn
Copy link
Member

Merging this!
Thanks for the contribution @voidquark, Looking forward to this one in the wild!

@ishanjainn ishanjainn merged commit 8783246 into grafana:main Apr 29, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants