-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add loki role #188
feat: add loki role #188
Conversation
cc @GVengelen as you had mentioned about adding a Loki role, Do you wanna take a pass at this too? |
Yes, will have a look this weekend |
@voidquark looks to me. To be inline with other roles, could you add examples? |
@GVengelen I've included two examples in 7be7334 . One demonstrates a simple default role deployment, while the other showcases a local filesystem deployment with retention settings and an example alerting rule. |
LGTM me too! Also, Like i mentioned to @GVengelen aswell, Do you wanna write. a blogpost on the grafana's blog about this role, If yes, Could you share the google doc link(Can be empty for now, Just need the link so that I can check it later once you have it completed) |
@ishanjainn I have accepted the invitation. |
@ishanjainn Once merged. I'll keep you updated on the progress of the blog post via Slack. |
Merging this! |
solving issue - #187
Migration of https://github.com/voidquark/loki into the Grafana collection.
I've integrated molecule testing for the Loki role, leveraging the same approach used in the previous repository. Results are under
actions->loki-molecule
.