Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alloy_user_groups variable again #276

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Allow alloy_user_groups variable again #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/alloy/tasks/install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

- name: Create alloy user
ansible.builtin.user:
name: "{{ alloy_service_user }}"

Check warning on line 15 in roles/alloy/tasks/install.yml

View workflow job for this annotation

GitHub Actions / Perform Linting

jinja[spacing] 

Jinja2 spacing could be improved: {{ [ alloy_service_group ] + alloy_user_groups }} -> {{ \[alloy_service_group] + alloy_user_groups }}
group: "{{ alloy_service_group }}"
group: "{{ [ alloy_service_group ] + alloy_user_groups }}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be groups:

system: true
create_home: false # Appropriate for a system user, usually doesn't need a home directory
become: true
Expand All @@ -26,7 +26,7 @@
become: true
register: alloy_download_result

- name: Remove existing alloy binary

Check failure on line 29 in roles/alloy/tasks/install.yml

View workflow job for this annotation

GitHub Actions / Perform Linting

no-handler 

Tasks that run when changed should likely be handlers.
ansible.builtin.file:
path: "{{ alloy_installation_dir }}"
state: absent
Expand Down
Loading