fix: use ansible_facts instead of ansible_* variables #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleini
requested review from
voidquark,
ishanjainn,
GVengelen,
gardar and
v-zhuravlev
as code owners
|
|
kleini
force-pushed
the
ansible-inject-fact-vars
branch
2 times, most recently
from
ee8df58 to
c7e8348
Compare
|
Some more background, why it is useful to not use ansible_* vars anymore: ansible/ansible#73654 |
|
@voidquark any thoughts? |
want test it first |
gardar
approved these changes
Dec 5, 2024
voidquark
approved these changes
Dec 12, 2024
|
I tested it and did not find any issues 🚀 . Approved, but I think you should resolve the conflict, @kleini. |
to allow ANSIBLE_INJECT_FACT_VARS to become false
kleini
force-pushed
the
ansible-inject-fact-vars
branch
from
c7e8348 to
a8bee2b
Compare
|
Conflicts are resolved @voidquark |
|
@ishanjainn I can't merge this PR. If you have time, could you merge it? 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow ANSIBLE_INJECT_FACT_VARS to become false