Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Plugin: Use Yarn Berry for new scaffolds #1438

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Create Plugin: Use Yarn Berry for new scaffolds #1438

wants to merge 5 commits into from

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Jan 8, 2025 •
edited by grafana-plugins-platform-bot bot
Loading

What this PR does / why we need it:

This PR changes create-plugin so plugin scaffolds that are run with yarn 1 scaffolds the plugin to use yarn berry (4.x.). Any other version of Yarn that is used to run create-plugin will have it's config set to nodeLinker: node-modules for compatibility with tooling / ci scripts.

Yarn 1 is considered deprecated and contains bugs that were only fixed in newer major versions. The sooner plugin devs move away from it the better.

Test scaffold and CI checks repo.
Test PR for gh workflows.
Test release gh workflows

This does not affect create-plugin update command.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install [email protected]
npm install @grafana/[email protected]
# or 
yarn add [email protected]
yarn add @grafana/[email protected]

@jackw jackw requested a review from a team as a code owner January 8, 2025 15:42
@jackw jackw requested a review from Ukochka January 8, 2025 15:42
@jackw jackw changed the title Jackw/use yarn berry Create Plugin: Use Yarn Berry Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@jackw jackw self-assigned this Jan 8, 2025
@jackw jackw marked this pull request as draft January 8, 2025 15:43
@jackw jackw added minor Increment the minor version when merged release Create a release when this pr is merged create-plugin related to the create-plugin tool labels Jan 8, 2025
@jackw jackw marked this pull request as ready for review January 9, 2025 09:40
@jackw jackw changed the title Create Plugin: Use Yarn Berry Create Plugin: Use Yarn Berry for new scaffolds Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ukochka Ukochka Awaiting requested review from Ukochka Ukochka is a code owner automatically assigned from grafana/plugins-platform-frontend

At least 1 approving review is required to merge this pull request.

Assignees

@jackw jackw

Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged
Projects
Plugins Platform / Grafana Community
Status: 🔬 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jackw