-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ESM build #193
feat: add ESM build #193
Conversation
@@ -36,7 +38,7 @@ | |||
"dev:test": "jest --watch", | |||
"format": "prettier --write .", | |||
"prepublishOnly": "yarn build", | |||
"build": "rm -rf dist && tsc -d", | |||
"build": "rm -rf dist && tsc -d && tsc -p tsconfig.esm.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a tsconifg for cjs
too please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default tsconfig.json
is already for cjs
. Do you want me to create a tsconfig.cjs.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping
Hi! I'd love to pick this up so we can get |
@Evalir just the comments you see here |
Alright! I'll pick this up in the following days 😃 |
I'm trying to get What do I need to do to fix this, other than fix these conflicts ↑? EDIT: I guess the reason the directory is empty is because EDIT: Adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
closes #192