-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show beam ref sides #378
base: main
Are you sure you want to change the base?
Show beam ref sides #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add a screenshot of what the new component shows vs. the one you deleted?
we could also combine them to still have a text label and show the origin corner. The big question is index starts at 0 or 1? |
I find it hard to climb down from my zero-based tree ;) I vote for 0. |
Same here, I think combining the components would be better. The old one was handy for quickly verifying the ref side with the tags. Also, I totally agree that showing the origin corner makes sense for clarity. As for indexing, I'd stick to the zero-based too :) |
I made the suggested changes:
cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, just fix an icon
This changes
Show_beam_faces
gh component toShow_beam_ref_side
, which now takes anint
index and shows the corresponding face including origin corner.What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_timber.datastructures.Beam
.