Make reports load much faster #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #451 but was quite painful. I needed to subclass
CommandLineReportto remove very costly individual DB calls to every object in the database for multiple reports. This was made harder by Gramps using name mangling in the parent class 🙄Even with this patched, it was still kind of slow and I realized that for Gramps Web, there is no point in even building the options help for all reports when just showing the list. So I added a new API parameter
include_helpwhich defaults tofalsefor/reports/andtruefor/reports/<id>. This might seem strange and is strictly speaking not backwards compatible for the API, but it allows a backwards compatible change for Gramps Web, since the frontend doesn't need to be changed.