type_ridge: joint.max=all/facet/by instead of global.max=TRUE/FALSE #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grant @grantmcdermott, this is a follow-up to our discussion in #270
I replaced the old
global.max = TRUE
vs.FALSE
argument with a newjoint.max = "all"
vs."facet"
or"by"
. The documentation reads as follows.joint.max
: character indicating how to scale the maximum of the densities: The default"all"
indicates that all densities are scaled jointly relative to the same maximum so that the areas of all densities are comparable. Alternatively,"facet"
indicates that the maximum is computed within each facet so that the areas of the densities are comparable within each facet but not necessarily across facets. Finally,"by"
indicates that each row (in each facet) is scaled separately, so that the areas of the densities forby
groups in the same row are comparable but not necessarily across rows.