Make tinytheme() play nicer with ridge and spineplot types
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantmcdermott
changed the title
tinytheme() play nicer with ridge and spineplot types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
(At least, mostly fixed. There's one outstanding issue with overlapping facet y labels for themes where
frame.plotis turned off like"clean2". But I can't see a way to address that under the current logic, since we can't pass this information from where it is calculated here to wheretype_ridge()actually draws the axis labels here.)See updated tests for some examples.
P.S. I thought about implementing a dedicated
tinytheme("ridge")theme, but decided against it for now. If implemented, we probably want solid grid lines (only on the y axis?) and potentially bump the (horizontal) axis labels up by passingpadj = 0totinyAxishere.