Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(helpers): pass client instead of pool; fix typing #379

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

bchrobot
Copy link

Description

This fixes passing the client to test helpers instead of the pool. It also adds typings to the pools cache to allow TS to catch future mismatches.

Performance impact

Presumably none.

Security impact

Presumably none.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benjie benjie merged commit 1b00e44 into graphile:v5 Apr 23, 2024
3 of 5 checks passed
@bchrobot bchrobot deleted the fix-helper-typing branch April 23, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants