personal key auth

[mj3cheun]

solves #80

includes feature code and documentation

example of pkey interface in use:

import {ClientPkey,} from '@graphistry/client-api';
const client = new ClientPkey('TQGURJJD42', '9XOES9I0C2QZDLEY', '', 'http', 'localhost');

[lmeyerov]

same, AbstractClient, right?

[lmeyerov]

Awesome, agreed w/ decision to separate out the base client from diff authentication entrypoints

• js-upload-api is an internal class; we should export ClientPKey + AbstractClient to client-api, client-api-react, node-api for per-environment use. This may require a similar dual-client export, e.g., export class ClientPKey extends ClientPKeyBase:

  graphistry-js/projects/node-api/src/index.ts

  Line 19 in 3d069ba

  export class Client extends ClientBase {

• instead of hard-coding Client | ClientPkey everywhere, we should be passing around AbstractClient where possible, or a new interface ClientI

• I was a bit unsure about error handling, esp for explainability for devs + propagating to end-users

After this one goes in, we may want a quick follow-up on ensuring docs go through too (or as part, either way)

[mj3cheun]

lets split this into two, this first part can go in alone and the second part which will include changes to graphistry/graphistry in order to allow POST to the pkey endpoint and re-add org to @graphistry/client-api can go in afterwards. i believe everything has been addressed.

[lmeyerov]

can we drop the debug statements, as they'll be in customer code vs ours?

[lmeyerov]

(i'm esp thinking any that print the creds)

[lmeyerov]

• Approved, tho plz remove console.debug of creds

• Splitting sounds good, tho I didn't understand what this is about, this is about using existing Graphistry pkey endpoints?

graphistry/graphistry in order to allow POST

• RE:Graphistry upgrade follow-on to use the new client, great. We can pair th/f and I walk you through npm publishing, and after that, you have the client

FWIW, have you done live testing, e.g., in storybook + node, or elsewhere?

[mj3cheun]

1. credential debug statements dropped
2. yes this is about not being able to utilise the existing pkey auth endpoint wrt sending org info to the backend because of fetch limitations
3. i have done testing in node, thats fully working. i tried testing for react but there is an issue there with the api client-api-react is designed to work with, will carry on the convo in slack