Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(indexer-service): Sender denylist #109

Merged
merged 4 commits into from
Jan 23, 2024
Merged

feat(indexer-service): Sender denylist #109

merged 4 commits into from
Jan 23, 2024

Conversation

aasseman
Copy link
Contributor

@aasseman aasseman commented Jan 9, 2024 •
edited
Loading

indexer-service will reject all paid queries from denied senders. Denylist DB table updates are watched through PG notifications.

Part of the solution for #103

@aasseman aasseman added size:medium Medium p2 Medium priority type:feature New or enhanced functionality labels Jan 9, 2024
@aasseman aasseman requested review from Jannis and gusinacio January 9, 2024 03:25
@aasseman aasseman self-assigned this Jan 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7549859928

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 63.382%
Totals Coverage Status
Change from base Build 7549373716: 1.0%
Covered Lines: 2470
Relevant Lines: 3897
💛 - Coveralls

gusinacio
gusinacio reviewed Jan 9, 2024
View reviewed changes
common/src/tap_manager.rs Outdated Show resolved Hide resolved
@aasseman aasseman requested a review from gusinacio January 10, 2024 01:22
@aasseman aasseman force-pushed the aasseman/indexer-service-denylist branch 2 times, most recently from 0b83d7d to 6f263c5 Compare January 10, 2024 01:27
@aasseman aasseman marked this pull request as draft January 13, 2024 00:50
@aasseman
Copy link
Contributor Author

Making it draft until #110 gets merged

@aasseman aasseman requested a review from gusinacio January 15, 2024 18:17
gusinacio
gusinacio previously approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman
feat(indexer-service): Sender denylist
bce70bb 
indexer-service will reject all paid queries from denied senders.
Denylist DB table updates are watched through PG notifications.

Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
refactor: cleaner sender_denylist_watcher shutdown
5713562 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
refactor: remove unnecessary Arc on CancellationToken
3bfec00 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman aasseman force-pushed the aasseman/indexer-service-denylist branch from fbaf97e to 3bfec00 Compare January 17, 2024 01:36
@aasseman aasseman marked this pull request as ready for review January 17, 2024 01:49
@aasseman aasseman requested a review from gusinacio January 17, 2024 01:49
gusinacio
gusinacio approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman merged commit be4ad96 into main Jan 23, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/indexer-service-denylist branch January 23, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

@Jannis Jannis Awaiting requested review from Jannis

Assignees

@aasseman aasseman

Labels
p2 Medium priority size:medium Medium type:feature New or enhanced functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aasseman @gusinacio