-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use tokio::watch for escrow_accounts
#413
Conversation
terribly sorry for the delay, I first tried the fix using Receiver<Option>, although it was not required, was reluctant to skip some error checks, please have a look when you're free also please tell me if any changes are required. |
Pull Request Test Coverage Report for Build 11641140606Details
💛 - Coveralls |
hi, updated with initial accounts, please have a look when you're free, tell me if any more changes are required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey this is all really nice. Just two missed comments.
Now that you removed all eventuals, could you also remove it from the dependencies? Let me know how it goes, I suppose it's not used anywhere anymore.
Thanks for the review, Eventual is still used in couple of places for other variables, I'll change it and push asap. |
BTW, I have send a connection request on linkedin please accept😁 |
Hi, the last commit is not the fix. I had to push due run on diff system, I'll let you know when it's ready |
Hi sir, it's ready, please review when you're free, also tell me if any changes are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I'm sorry that you had to upgrade two more eventuals here, I thought that those 4 were the only ones.
As you may suspect, I don't like eventuals that contains None or default values. IMO this is the biggest flaw with eventuals.
Thanks for the review I'll send the update asap. |
Hey, quick thing: I added a module called |
sure, I'll check it out |
Hi, checked out new module, and it's lit[🔥], highly needed, repetitive components was getting little weird, I think it's better to change that in a new PR, cause this PR itself is little lengthier besides we should update all channels. |
Hi, update the code, please have a look when you're free, it have gotten little longer, but I hope the size doesn't matter cause most of it is already reviewed, important change is that, dummy_url cannot be used in the test anymore cause we don't have empty values and request cant go wrong while creation. Also tell me if any changes are required. |
Hey @taslimmuhammed, actually, it got way harder to review. Sorry, it was a bad decision to remove the all eventual. Can we split this PR in:
Also, if I'm missing any eventual, do it in a separate PR. We were almost ready with this but the newer changes were too much, I'm sorry again. |
Also, add me in Discord: gustavoinacio |
It's ok, I'll send the commit asap, BTW it's better to convert all elements to use |
Hi, it's ready, have a look when you're free, also tell me if any more changes are needed |
me too never thought changing 2 small eventuals, would become this large😂, it truly caused a chain reaction, they are utilized in almost everywhere. |
Hi, please note this is the same code reviewed above, I just moved backwards. Also regarding other updates, if it's ok, no need of new issue, I'll send new PR for each eventuals and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, way easier to review. There's only one function that we can use it and all the rest LGTM.
let escrow_accounts = state.escrow_accounts.clone(); | ||
let sender = escrow_accounts | ||
.borrow() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't need to clone here.
thanks, i'll send the fixes asap |
Hi, it's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! This is the last review
Hi, updated[✌️] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
escrow_accounts
escrow_accounts
thanks alot sir[🫂] |
Thank you @taslimmuhammed! |
Fixes #365