Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check subgraph before closing allocations #435

Conversation

gusinacio
Copy link
Member

No description provided.

@gusinacio gusinacio force-pushed the gustavo/tap-265-dont-mark-as-last-in-case-theres-a-failure-in-network branch from 5ed86ea to 6205d7b Compare October 30, 2024 16:36
@gusinacio gusinacio requested a review from carlosvdr October 30, 2024 16:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11597645732

Details

  • 85 of 90 (94.44%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 74.813%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent.rs 0 1 0.0%
tap-agent/src/agent/sender_account.rs 80 84 95.24%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 98.21%
Totals Coverage Status
Change from base Build 11587066283: 0.2%
Covered Lines: 5305
Relevant Lines: 7091

💛 - Coveralls

@gusinacio gusinacio self-assigned this Oct 30, 2024
@gusinacio gusinacio merged commit a3cc07e into main Oct 30, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/tap-265-dont-mark-as-last-in-case-theres-a-failure-in-network branch October 30, 2024 17:43
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants