Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper build graph-node query url #438

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

gusinacio
Copy link
Member

@gusinacio gusinacio commented Oct 30, 2024

We had a refactor(#409) that updated the duplication of code in configurations. But while doing that, status_url was misconfigured. With the latest refactor (#428), we crash early if we cannot start some services.

Indexer service on version 1.2.0 is not capable of starting up if you provide local deployment (graph-node + deployment_id)

@gusinacio gusinacio requested a review from shiyasmohd October 30, 2024 17:58
@gusinacio gusinacio force-pushed the gustavo/fix-local-graphnode-query branch from 2f34d9f to 12cfc8d Compare October 30, 2024 17:59
@gusinacio gusinacio requested a review from carlosvdr October 30, 2024 18:31
@gusinacio gusinacio changed the title fix: only use local-client if deployment_id is defined fix: proper build graph-node query url Oct 30, 2024
@gusinacio gusinacio requested a review from anirudh2 October 30, 2024 20:22
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked offline about this PR.

@gusinacio gusinacio merged commit df94692 into main Oct 30, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/fix-local-graphnode-query branch October 30, 2024 20:43
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants