Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use tokio::watch for subgraph monitor #444

Conversation

shiyasmohd
Copy link
Contributor

Fixes #440

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Pull Request Test Coverage Report for Build 11629997961

Details

  • 96 of 208 (46.15%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 74.482%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/attestations/dispute_manager.rs 1 2 50.0%
tap-agent/src/agent/sender_accounts_manager.rs 12 13 92.31%
tap-agent/src/agent/sender_allocation.rs 6 7 85.71%
tap-agent/src/agent/sender_account.rs 12 14 85.71%
common/src/subgraph_client/monitor.rs 45 48 93.75%
common/src/subgraph_client/client.rs 18 22 81.82%
common/src/allocations/monitor.rs 0 10 0.0%
tap-agent/src/agent.rs 0 40 0.0%
common/src/indexer_service/http/indexer_service.rs 0 50 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/subgraph_client/client.rs 1 77.38%
common/src/allocations/monitor.rs 1 0.0%
Totals Coverage Status
Change from base Build 11602628063: -0.07%
Covered Lines: 5321
Relevant Lines: 7144

💛 - Coveralls

Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this code, really nice.

Just a small suggestion, also the ci is failing.

common/src/subgraph_client/monitor.rs Outdated Show resolved Hide resolved
@shiyasmohd
Copy link
Contributor Author

@gusinacio Thanks for the review. Pushed the changes and ci checks are now passed.

Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio changed the title refactor: drop eventuals in favor of tokio watch + timers for subgraph monitor refactor: use tokio::watch for subgraph monitor Nov 1, 2024
@gusinacio gusinacio merged commit fe6219b into main Nov 1, 2024
10 checks passed
@gusinacio gusinacio deleted the shiyasmohd/drop-eventuals-and-use-tokio-watch-in-subgraph-monitor branch November 1, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop eventuals in favor of Tokio watch + timers for subgraph monitor
2 participants