Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use graphql-client for status monitor #486

Merged
merged 2 commits into from
Nov 13, 2024
Merged

refactor: use graphql-client for status monitor #486

merged 2 commits into from
Nov 13, 2024

Conversation

taslimmuhammed
Copy link
Contributor

Fixes #421

@taslimmuhammed
Copy link
Contributor Author

Hi, first time dealing with graphql-client, I hope everything's good, if any or full change[😅] required please tell me.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11812954377

Details

  • 17 of 19 (89.47%) changed or added relevant lines in 1 file are covered.
  • 34 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.4%) to 72.505%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/common/src/subgraph_client/monitor.rs 17 19 89.47%
Files with Coverage Reduction New Missed Lines %
crates/common/src/subgraph_client/monitor.rs 2 97.89%
crates/common/src/watcher.rs 4 94.44%
crates/common/src/subgraph_client/client.rs 28 70.86%
Totals Coverage Status
Change from base Build 11809937770: -0.4%
Covered Lines: 5704
Relevant Lines: 7867
💛 - Coveralls

gusinacio
gusinacio approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio changed the title Use graphql-client for status monitor refactor: use graphql-client for status monitor Nov 13, 2024
@gusinacio gusinacio merged commit 24b558c into graphprotocol:main Nov 13, 2024
6 of 7 checks passed
@taslimmuhammed
Copy link
Contributor Author

well that was truly unexpected😂, BTW thanks alot for the review as always[🫂]

@gusinacio
Copy link
Member

well that was truly unexpected😂, BTW thanks alot for the review as always[🫂]

Thank you for the incredible code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use graphql-client for status monitor
3 participants
@taslimmuhammed @coveralls @gusinacio