agent,service: improve exception handling #844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To be upgraded again once Dockerfile and workflows are upgraded
Introducing `uncaughtException` and `unhandledRejection` handlers and gracefully shutdown the process.
|
We already have similar code paths in the |
fordN
reviewed
Jan 24, 2024
There was a problem hiding this comment.
We already have similar code paths in the /commands/start.ts files of both indexer-service and indexer-agent. I see that this is one level up in the index.ts files, but I wonder if there is opportunity to unify the approaches?
|
yeah you are right we don't then technically need cause that is already picking up from the process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing
uncaughtExceptionandunhandledRejectionhandlers and gracefully shutdown the process.