Add traceback to errors from failed promises #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2019
The stack attribute of GraphQLLocatedErrors was not set for errors that resulted from asynchronous resolvers. We add a unit test for this problem and a solution that works with Python >= 3. In Python 2 this problem is not yet solved, and may be never solved, because dealing with stack traces is much more difficult there.
ProjectCheshire
approved these changes
Jun 2, 2019
|
@Cito merge whenever you're ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack attribute of GraphQLLocatedErrors was not set for errors that resulted from asynchronous resolvers.
This PR adds a unit test for this problem and a solution that works with Python >= 3 and solves #237.
For Python 2 this problem is not yet solved, and may be never solved, because dealing with stack traces is much more difficult there.