This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
CI: Update teleport version to 15.2.0 #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
marcoandredinis
force-pushed
the
marco/update_teleport_version_ci_15-1-9
branch
from
f1183bc to
4319052
Compare
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
marcoandredinis
force-pushed
the
marco/update_teleport_version_ci_15-1-9
branch
from
4319052 to
c916651
Compare
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
marcoandredinis
force-pushed
the
marco/update_teleport_version_ci_15-1-9
branch
from
c916651 to
bb5ff0d
Compare
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
marcoandredinis
changed the title
marcoandredinis
changed the title
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
This new version of teleport has the following relevant changes: * Teleport process logging uses `log/slog` For terraform tests we start a teleport binary and parse its output to understand when the Auth/Proxy service started and what ports are they listening on. We used a regex for that, but teleport migrated to `log/slog` and the regex no longer works. Migration PR: gravitational/teleport#38551 We had to fix the regex for integration tests in teleport: gravitational/teleport#39315 Terraform Tests also use that library, so after the regex changed, we must upgrade Teleport CI version to get the new log format. * Teleport API: `GetClusterNetworkingConfig` and `GetSessionRecordingConfig` never return a nil When developing the `ClusterMaitenanceConfig` we had to include a nil check, because if it was never configured, `GetClusterMaintenanceConfig` would return a nil object. This nil check was added to all SingleResource resources. For `ClusterNetworkingConfig` and `SessionRecordingConfig`, the `Get` operation never returns a nil resource and `staticcheck` linter was yelling about it. So, we had to create a new flag to ensure we only nil-checked the resources that can actually return a nil value. * Teleport Resource Metadata It is no longer recommended to use the `<Resource>.Metadata.ID` to check for cached responses. We are now using the revision field. During this change we also detected a miss-usage of an `error` variable and fixed that (could lead to a panic). LoginRules didn't have the `Revision` field, so we added it here: gravitational/teleport.e#3821 Unfortunately, that PR didn't merge in time for 15.2.0. However, that's ok because LoginRules are not cached. So, instead of waiting for a new release (15.2.1), we just removed the cache check.
marcoandredinis
force-pushed
the
marco/update_teleport_version_ci_15-1-9
branch
from
c233311 to
0d0a5ac
Compare
marcoandredinis
temporarily deployed
to
build-stage
GitHub Actions
Inactive
marcoandredinis
requested review from
klizhentas,
russjones,
r0mant,
Joerger,
tcsc,
zmb3,
camscale and
fheinecke
as code owners
hugoShaka
approved these changes
Apr 2, 2024
| @@ -103,7 +103,7 @@ release: build | |||
| endif | |||
| tar -C $(BUILDDIR) -czf $(RELEASE).tar.gz . | |||
|
|
|||
| TERRAFORM_EXISTS := $(shell terraform -version 2>/dev/null | grep 'Terraform v1.5') | |||
| TERRAFORM_EXISTS := $(shell terraform -version 2>/dev/null | grep 'Terraform v1.') | |||
There was a problem hiding this comment.
Is this change intentional? Do we want to force a specific TF version or we're OK with everything 1.x?
There was a problem hiding this comment.
Yes, but I can add it into another PR if you think it's better
I think requiring anything in the 1.x range is fine, and I was getting annoyed with having to upgrade multiple things
marcoandredinis
commented
Apr 2, 2024
rosstimothy
approved these changes
Apr 2, 2024
|
@r0mant Can you please take a look? I need a code owners review |
r0mant
approved these changes
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Teleport binary used in tests to 15.2.0
This new version of teleport has the following relevant changes:
Teleport process logging uses
log/slogFor terraform tests we start a teleport binary and parse its output to understand when the Auth/Proxy service started and what ports are they listening on.
We used a regex for that, but teleport migrated to
log/slogand the regex no longer works.Migration PR: gravitational/teleport#38551
We had to fix the regex for integration tests in teleport: gravitational/teleport#39315
Terraform Tests also use that library, so after the regex changed, we must upgrade Teleport CI version to get the new log format.
Teleport API:
GetClusterNetworkingConfigandGetSessionRecordingConfignever return a nilWhen developing the
ClusterMaitenanceConfigwe had to include a nil check, because if it was never configured,GetClusterMaintenanceConfigwould return a nil object.This nil check was added to all SingleResource resources.
For
ClusterNetworkingConfigandSessionRecordingConfig, theGetoperation never returns a nil resource andstaticchecklinter was yelling about it.So, we had to create a new flag to ensure we only nil-checked the resources that can actually return a nil value.
Teleport Resource Metadata
It is no longer recommended to use the
<Resource>.Metadata.IDto check for cached responses.We are now using the revision field.
During this change we also detected a miss-usage of an
errorvariable and fixed that (could lead to a panic).LoginRules didn't have the
Revisionfield, so we added it here: https://github.com/gravitational/teleport.e/pull/3821Unfortunately, that PR didn't merge in time for 15.2.0.
However, that's ok because LoginRules are not cached.
So, instead of waiting for a new release (15.2.1), we just removed the cache check.