This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Fix BoolOpts for ProvisionToken #1059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
had a problem deploying
to
build-stage
GitHub Actions
Failure
strideynet
had a problem deploying
to
build-stage
GitHub Actions
Failure
strideynet
commented
Apr 30, 2024
strideynet
changed the title
strideynet
requested review from
klizhentas,
russjones,
r0mant,
Joerger,
tcsc,
zmb3,
camscale and
fheinecke
as code owners
|
Superseded by #1065 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gravitational/teleport#42432
Fixes a fairly nasty bug in the CopyFromBoolOption helper whereby null values were not properly handled. Unfortunately, fixing this generally probably risks breaking folks who rely on the bad behaviour of this function. So for now, we've generated the provision token schema separately and with its own helpers. Eventually we can roll this new behaviour out to all resources.
A good thing to look at would be the different between the
custom_types.goin this PR and the unchanged one on master.