This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Fix update_goversion target to update go.mod's toolchain
#950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
requested review from
klizhentas,
russjones,
r0mant,
Joerger,
tcsc,
zmb3,
camscale and
fheinecke
as code owners
reedloden
reviewed
Oct 11, 2023
reedloden
reviewed
Oct 11, 2023
Makefile
Outdated
| @@ -289,9 +293,6 @@ update-goversion: | |||
| $(SED) 's/Setup Go .*/Setup Go $(GOVERSION)/g' .github/workflows/unit-tests.yaml | |||
There was a problem hiding this comment.
These can be removed as well, no?
There was a problem hiding this comment.
Yes 👍
Removed
reedloden
approved these changes
Oct 12, 2023
r0mant
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
update_goversionMakefile's target to include some extra locations.It also updates the
tooling/go.modto use the latest go version (we were targeting 1.18) and update somegolang.org/x/packages.