This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Release 14.0.3 #952
Merged
Release 14.0.3 #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcsc
requested review from
klizhentas,
russjones,
r0mant,
Joerger,
zmb3,
camscale and
fheinecke
as code owners
camscale
approved these changes
Oct 12, 2023
| @@ -133,10 +133,19 @@ spec is the specification for the access list. | |||
|
|
|||
| audit describes the frequency that this access list must be audited. | |||
|
|
|||
| | Name | Type | Required | Description | | |||
| |-----------------|--------------|----------|-------------| | |||
| | frequency | duration | | | | |||
There was a problem hiding this comment.
Totally unrelated to the release PR but we should not be deleting fields.
This might cause breakage on users.
There was a problem hiding this comment.
This was for an unreleased feature so I think it should be ok in this case.
add test for access list audit recurrence frequency improve fluentfake used in tests It was using the content length of the http request and it included some extra chars "\x0". We are now using the `io.ReadAll` from the Body instead of pre-creating the array.
marcoandredinis
force-pushed
the
release/14.0.3
branch
from
890a7d0 to
b3335bd
Compare
marcoandredinis
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.