feat: update pods deployment labels

[thib-mary]

Describe your changes

Update labels in the pod template spec of the deployment to include the full set of labels and not just the selector labels.

[thib-mary]

Hi klizhentas, russjones, r0mant, Joerger, tcsc, zmb3, camscale and fheinecke, could i have a review please ? 🙏

[camscale]

@thib-mary Would you describe your changes a little more please? Describe the change as you see it and why this should be done. Something like:

Change the labels in the pod template spec of the deployment in the slack chart to include the full
set of labels and not just the selector labels. This includes the help chart, app version and managed-by labels.
These are needed because ...

The reason I ask is because it seems wrong to set the managed-by label to helm as helm does not manage the pod. Some of the other labels may make sense.

However if this change does make sense, it needs to be made to all the helm charts and not just for slack. I've asked for the team's input into why the labels might have been limited to just the selector labels. I'll update this when I find out more.

[camscale]

@thib-mary I've verified with the team that this change is correct and is how the helm chart should have been written. Would you like to update all the helm charts to fix this across the repo, or would you prefer I do that? Happy either way.

I've approved the workflow runs so you can see that there are tests that are failing now because of this change. But looking at them now, it seems there are some other tests failing perhaps due to unrelated changes that I will need to look into.

[thib-mary]

@thib-mary I've verified with the team that this change is correct and is how the helm chart should have been written. Would you like to update all the helm charts to fix this across the repo, or would you prefer I do that? Happy either way.

I've approved the workflow runs so you can see that there are tests that are failing now because of this change. But looking at them now, it seems there are some other tests failing perhaps due to unrelated changes that I will need to look into.

Thanks for the review. I have updated the pull request to update all the concerned helm charts.

[tigrato]

Hi @thib-mary,

Thanks for your contribution. We are currently unable to run our tests on
external contributions. As such, I'll be helping you validate and
merge your pull request. I've created an internal PR here:

#1013

Please wait for another approver and I'll get your
code merged. You will retain authorship of your commits.