This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Terraform Provider: Use updated APIs for Users, Roles, & Auth Connectors #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/update_apis
branch
3 times, most recently
from
b27c487 to
902b2a2
Compare
rosstimothy
requested review from
klizhentas,
russjones,
r0mant,
Joerger,
tcsc,
zmb3,
camscale and
fheinecke
as code owners
rosstimothy
force-pushed
the
tross/update_apis
branch
2 times, most recently
from
89c3f46 to
f4ec9de
Compare
|
If we're switching to the APIs which return the created/updated resource, we can probably remove the logic which tries to Get the resource after the create/update. |
I was under the impression that behavior existed to prevent cache propagation delay from impacting future calls to Get. |
rosstimothy
force-pushed
the
tross/update_apis
branch
2 times, most recently
from
01a44c0 to
130284b
Compare
hugoShaka
approved these changes
Jan 16, 2024
marcoandredinis
approved these changes
Jan 16, 2024
rosstimothy
force-pushed
the
tross/update_apis
branch
from
130284b to
9583a01
Compare
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
 Failed |
Vulnerabilities | 0 1 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
r0mant
approved these changes
Jan 30, 2024
The resources now all expose a Create, Update, Upsert RPC which returns the resource and an error. The generated code now uses Create for creating resources and Upsert for updating resources. The Update RPC is not used because it enforces optimistic locking which breaks the ownership model expected by the provider. Additionally, the GetUser RPC now takes a context so the hack to accommodate it has been removed.
hugoShaka
force-pushed
the
tross/update_apis
branch
from
9583a01 to
7e95025
Compare
hugoShaka
force-pushed
the
tross/update_apis
branch
from
e8fbf99 to
4b0e2f0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resources now all expose a Create, Update, Upsert RPC which returns the resource and an error. The generated code now uses Create for creating resources and Upsert for updating resources. The Update RPC is not used because it enforces optimistic locking which breaks the ownership model expected by the provider. Additionally, the GetUser RPC now takes a context so the hack to accommodate it has been removed.
- Do Not Merge Until v15 -
The APIs used in this PR are not being backported to v14 so this cannot land until the
gravitational/teleport-pluginsrepo is updated to point to branch/v15 ofgravitational/teleport. go.mod was updated in this PR to point at a commit of master fromgravitational/teleportso that the functionality could be validated.