This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedloden
reviewed
Dec 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Infrastructure as Code | 0 1 2 0 | View in Orca |
Failed | Vulnerabilities | 0 1 0 0 | View in Orca |
Passed | Secrets | 0 0 0 0 | View in Orca |
fheinecke
force-pushed
the
fred/gha-migration-1
branch
3 times, most recently
from
January 18, 2024 07:44
20bc867
to
53f27a2
Compare
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 09:37 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 09:42 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 09:44 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 09:48 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 09:51 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 09:57 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 09:59 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 10:02 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 10:10 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 10:19 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 10:26 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 11:10 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 11:16 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 11:22 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 11:37 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
build-stage
January 18, 2024 11:43 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
publish-stage
January 18, 2024 12:06 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
publish-stage
January 18, 2024 12:08 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
publish-stage
January 18, 2024 12:09 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
publish-stage
January 18, 2024 12:17 — with
GitHub Actions
Failure
fheinecke
had a problem deploying
to
publish-stage
January 18, 2024 12:19 — with
GitHub Actions
Failure
BTW, I use You can easily install actionlint with |
camscale
approved these changes
Feb 15, 2024
fheinecke
force-pushed
the
fred/gha-migration-1
branch
from
February 15, 2024 23:20
e916978
to
95afbf1
Compare
fheinecke
temporarily deployed
to
build-stage
February 16, 2024 01:35 — with
GitHub Actions
Inactive
fheinecke
temporarily deployed
to
build-stage
February 16, 2024 01:55 — with
GitHub Actions
Inactive
fheinecke
temporarily deployed
to
build-stage
February 16, 2024 02:01 — with
GitHub Actions
Inactive
fheinecke
temporarily deployed
to
build-stage
February 16, 2024 02:20 — with
GitHub Actions
Inactive
fheinecke
temporarily deployed
to
build-stage
February 16, 2024 02:28 — with
GitHub Actions
Inactive
fheinecke
temporarily deployed
to
build-stage
February 16, 2024 02:29 — with
GitHub Actions
Inactive
fheinecke
temporarily deployed
to
publish-stage
February 16, 2024 02:34 — with
GitHub Actions
Inactive
fheinecke
temporarily deployed
to
build-stage
February 16, 2024 02:38 — with
GitHub Actions
Inactive
fheinecke
temporarily deployed
to
build-stage
February 16, 2024 02:49 — with
GitHub Actions
Inactive
fheinecke
temporarily deployed
to
build-stage
February 17, 2024 04:33 — with
GitHub Actions
Inactive
fheinecke
temporarily deployed
to
build-stage
February 17, 2024 04:34 — with
GitHub Actions
Inactive
fheinecke
had a problem deploying
to
build-stage
February 17, 2024 04:40 — with
GitHub Actions
Failure
fheinecke
temporarily deployed
to
publish-stage
February 17, 2024 04:40 — with
GitHub Actions
Inactive
fheinecke
had a problem deploying
to
build-stage
February 17, 2024 04:43 — with
GitHub Actions
Failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all currently used Drone pipelines for this repo to GHA.
This pull request is pretty large. I had originally planned to split it into several, however after getting started on this project I decided that it would take significantly more effort to do so. This is primarily due to the large amount of coupling between Drone pipelines, our infra, and our tooling.
Here is a list of the changes the PR includes:
.drone.yml
, and Drone references throughout the code base. This includes Makefile targets that were used exclusively for the Drone release process.clean
target. This doesn't add much (or any) value in a completely ephemeral environment, and really screws up parallel build processes.VERSION
variable in every Makefile can now be set via CLI. I also added some linkage to ensure that it is passed down to to Makefile calls inside of Dockerfile builds.teleport.e
-build-stage
,build-prod
,publish-stage
, andpublish-prod
. With this, production publishing access can be much more tightly controlled. Additionally, changes to the release process can be fully tested (less Houston integration) prior to merge. This should result in a much more reliable release process.Here is the remaining work that needs to be put on the backlog:
I still have a couple of corner cases to check, but I don't expect the PR to change much so I'm opening it for review now.