This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Helm: Improve compatibility with Machine ID #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
changed the title
subPath when mounting secrets
strideynet
requested review from
klizhentas,
russjones,
r0mant,
Joerger,
tcsc,
zmb3,
camscale and
fheinecke
as code owners
…tional/teleport-plugins into strideynet/machine-id-helm-chart
|
I've tested the Discord access plugin locally with both Machine ID and an old style secret containing a one-off identity file as described by the docs. |
hugoShaka
approved these changes
Dec 20, 2023
tigrato
approved these changes
Dec 20, 2023
zmb3
approved these changes
Dec 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #985
No longer use
subPathwhen mounting the identity file secretTo use Machine ID with plugins, the identity file changes regularly. The use of
subPathprevents this (from the k8s docs):Enable credential watching by default
Provides
refresh_identityby default to the configuration for plugins. There shouldn't be any adverse affects if Machine ID isn't being used.