profilealert fixes #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need for a shebang or chmod +x
ie. `/bin/dash` or 'busybox sh' do not have `source`. (the bash shebang we had before does NOT help, as this script itself is sourced into a running shell, not executed)
as sourcing it in profile.d will pollute the user's environment with all it's settings
as the return value of the profile.d entries is ignored
r00t-
force-pushed
the
profilealert_fixes
branch
from
33a73d3 to
02a6ff8
Compare
|
FYI, I've tested and integrated this patch in the Debian package. @r00t-, You need to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i installed chkboot (from debian unstable), and found a few issues with the profilealert script:
source, which is not available in all shells, and will cause errors(just set your login-shell to dash instead of bash and see yourself)
#!/bin/bashdoes NOT help, as profile scripts are sourced into whatever shell the user is usingsource-ing the defaults will will load all it's settings into every shell on the system,just try
echo $BOOTDISKafter login