Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user setting time date format #4144

Merged
merged 7 commits into from
Oct 16, 2024

address comments

c7b3f4b
Select commit
Loading
Failed to load commit list.
Merged

Add user setting time date format #4144

address comments
c7b3f4b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 16, 2024 in 0s

64.31% (-0.08%) compared to ed32a25

View this Pull Request on Codecov

64.31% (-0.08%) compared to ed32a25

Details

Codecov Report

Attention: Patch coverage is 53.98230% with 208 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (ed32a25) to head (c7b3f4b).
Report is 3 commits behind head on opensight-ui.

Files with missing lines Patch % Lines
src/web/pages/usersettings/usersettingspage.jsx 0.00% 72 Missing ⚠️
src/web/pages/usersettings/generalpart.jsx 0.00% 69 Missing ⚠️
src/web/pages/usersettings/dialog.jsx 0.00% 19 Missing ⚠️
src/web/pages/login/loginpage.jsx 71.87% 9 Missing ⚠️
src/web/utils/userSettingTimeDateFormatters.js 77.50% 9 Missing ⚠️
src/web/components/chart/schedule.jsx 16.66% 5 Missing ⚠️
src/web/pages/notes/detailspage.jsx 20.00% 4 Missing ⚠️
src/web/pages/overrides/detailspage.jsx 20.00% 4 Missing ⚠️
src/gmp/commands/users.js 62.50% 3 Missing ⚠️
src/web/pages/tasks/icons/scheduleicon.jsx 25.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files 
@@               Coverage Diff                @@
##           opensight-ui    #4144      +/-   ##
================================================
- Coverage         64.39%   64.31%   -0.08%     
================================================
  Files              1111     1111              
  Lines            103662   103884     +222     
  Branches           6466     6479      +13     
================================================
+ Hits              66755    66816      +61     
- Misses            36767    36929     +162     
+ Partials            140      139       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov