Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.3.2 #297

Merged
merged 7 commits into from
Jan 6, 2025
Merged

v1.3.2 #297

merged 7 commits into from
Jan 6, 2025

Conversation

vincerubinetti
Copy link
Collaborator

@vincerubinetti vincerubinetti commented Jan 6, 2025 •
edited
Loading

Closes #293
Addresses #294
Closes #295
Addresses #296

  • "pi" -> "principal-investigator" to encourage more specific names
  • add bluesky icon by default
  • fix header/footer/section background image regressions from v1.3.0
  • upgrade font awesome version
  • do full audit of changes from v1.3.0 and v1.3.1, and all _escape filters applied. make fixes/simplifications where applicable.

FOR THE TEMPLATE MAINTAINER(S)

New template version checklist:

  • I have updated CITATION and CHANGELOG as appropriate.
  • I have updated lab-website-template-docs as appropriate.
  • I have checked the testbed as appropriate.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2025-01-06 18:31 UTC

@vincerubinetti vincerubinetti mentioned this pull request Jan 6, 2025
Closed
1 task
falquaddoomi
falquaddoomi approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, looks good to me. Nice to see Bluesky being integrated, and the cleanups you've made in the template make sense.

@vincerubinetti vincerubinetti merged commit f065e00 into main Jan 6, 2025
4 checks passed
@vincerubinetti vincerubinetti deleted the v1.3.2 branch January 6, 2025 18:30
@vincerubinetti vincerubinetti mentioned this pull request Jan 15, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falquaddoomi falquaddoomi falquaddoomi approved these changes

@cgreene cgreene Awaiting requested review from cgreene

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"background" option in sections maybe not working? Add Bluesky to social media
2 participants
@vincerubinetti @falquaddoomi