Do not use "default" hardware profile #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkircher
suggested changes
May 9, 2021
bkircher
changed the title
hardware_profile when not set
|
Note: changed target branch to v2. We need to test update behavior from v1.x → v2 for this change. |
bkircher
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #141 . The server's field
hardware_profileis now computed. The propertyDefaultof the field is removed, so that ifhardware_profileis empty (not set), the default hardware profile will be determined by the gridscale backend (which isq35at the moment of writing). Back-compat is kept. However, @bkircher @itakouna please test on your machines to make sure the back-compat works as expected.Changes:
Defaultof fieldhardware_profilein server rs.hardware_profileto becomputed.