Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set backup location when creating a backup schedule. #193

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Allow to set backup location when creating a backup schedule. #193

merged 3 commits into from
Feb 9, 2022

Conversation

nvthongswansea
Copy link
Member

Ref #188 . Changes:

  • Add 2 fields: backup_location_uuid and backup_location_name in backup schedule datasource/resource.
  • Update docs of backup schedule datasource/resource.
  • Allow to specify the location of the backup schedule.

@nvthongswansea
add backup_location_uuid and backup_location_name
196ef37 
Which also means backup_location_uuid can be set for a backup schedule.
@nvthongswansea
update backup schedule docs
e2e827b
@nvthongswansea
make backup_location_uuid computed in bs rs
93ccbe5 
since it will be set by the backend automatically when the user doesn't set.
itakouna
itakouna approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@itakouna itakouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvthongswansea nvthongswansea merged commit 97780a6 into master Feb 9, 2022
@nvthongswansea nvthongswansea deleted the feature/backuplocation branch September 25, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itakouna itakouna itakouna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvthongswansea @itakouna