Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behavior to allow different percentile threshold strategies for candidates #1185

Open
wants to merge 12 commits into
base: staging
Choose a base branch
from
Open

Behavior to allow different percentile threshold strategies for candidates #1185

wants to merge 12 commits into from

Conversation

ldhtnp
Copy link
Contributor

@ldhtnp ldhtnp commented Jan 29, 2025

I added the parameter --percentile-threshold-strategy that currently does nothing. Further logic needs to be added to incorporate it downstream

Associated issue: #1142

@ldhtnp ldhtnp changed the base branch from master to staging January 29, 2025 21:51
@susannasiebert susannasiebert linked an issue Feb 4, 2025 that may be closed by this pull request
Allow passing candidates to be based on binding OR percentile cutoff. #1142
Open
@susannasiebert susannasiebert marked this pull request as ready for review February 7, 2025 20:46
@susannasiebert
Copy link
Contributor

@ldhtnp I think this is ready to be merged in. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susannasiebert susannasiebert susannasiebert left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing candidates to be based on binding OR percentile cutoff.
2 participants
@ldhtnp @susannasiebert