Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point to grommet stable #3638

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Point to grommet stable #3638

merged 1 commit into from
Jan 12, 2024

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Jan 12, 2024 •
edited
Loading

Deploy Preview

What does this PR do?

Point to grommet stable as opposed to styled components beta release in order to incorporate latest Data + friends behavior.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@taysea taysea requested a review from jcfilben January 12, 2024 23:36
jcfilben
jcfilben approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@taysea taysea merged commit bb6e0ab into master Jan 12, 2024
8 of 9 checks passed
@taysea taysea deleted the packagejson branch January 12, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfilben jcfilben jcfilben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taysea @jcfilben