Update search.mdx

[oliverHPE]

Have updated several sections of the search guidance to provide more accurate info.

Information updated includes:

Placeholder text
Icon position
Clear seach icon
Accessibility

The placeholder text on the 'don't' guidance needs to include: "Search first name, last name, email, role, location"and if possible is long enough to show truncation happening.

For the clear search icon, we have two examples we can show. One from Chrome and one from Safari. They're in the Figma file.

Thanks

[taysea]

Thanks, Oliver! I've made this PR with some suggestions to wording/adjusting examples.

The one thing I wasn't clear on was the rationale for when you would have the "Search" icon at the far right of the input. The rationale for having it before the placeholder text was clear, but feels like we have a gap for the other position. Can you add some content for that?

[oliverHPE]

Thanks, Oliver! I've made this PR with some suggestions to wording/adjusting examples.

The one thing I wasn't clear on was the rationale for when you would have the "Search" icon at the far right of the input. The rationale for having it before the placeholder text was clear, but feels like we have a gap for the other position. Can you add some content for that?

Okay I see, thanks Taylor. I didn't want to specify whether to use the icon on the left or right as there could be reasons to use either or. Also we don't seem to have a default preference. The point I was trying to get across is that the icon should be seen before the label is seen. Whether it's on the left or right, the icon should be seen first to help with scanning the page. If the icon is seen second, then it's more decoration and secondary support for the label rather than a primary way of locating the search input. I need to adjust the wording to make that more clear if you didn't pick that up. I think the word 'before' here could be the problem, as it seems like it is perhaps suggesting the icon 'before the label' means should be to the left of the label (in left to right reading languages). Saying the icon should be seen first is probably more clear and isn't recommending left or right.

[taysea]

LGTM, thanks Oliver for writing the content.

[jcfilben]

We talk about icon positioning in both the Search Icon/Placement section and the Variants/Icon position.

I think we should just have this information in one of these sections so we don't duplicate content.

Other than that everything else looks good!

[taysea]

We talk about icon positioning in both the Search Icon/Placement section and the Variants/Icon position.

I think we should just have this information in one of these sections so we don't duplicate content.

I incorporated this feedback! @jcfilben

[jcfilben]

Looks good!